chore: align plugin against enext branch #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideAligns all module imports, logging namespaces, plugin metadata, migration references, and log action types from pretix.* to eventyay.* to conform with the enext eventyay module structure. Entity relationship diagram for updated ReferencedPayPalObject modelerDiagram
ReferencedPayPalObject {
string reference
FK Order order
FK OrderPayment payment
}
Order ||--o{ ReferencedPayPalObject : "has"
OrderPayment ||--o{ ReferencedPayPalObject : "has"
Class diagram for updated PaypalPluginApp and plugin metaclassDiagram
class PaypalPluginApp {
name : str = "eventyay_paypal"
verbose_name : str = _("PayPal")
}
class EventyayPluginMeta {
name : str = _("PayPal")
author : str = "eventyay"
version : str = __version__
}
PaypalPluginApp <|-- EventyayPluginMeta
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Ensure that the migration dependency change from 'pretixbase' to 'base' does not disrupt the existing migration graph or require a data migration for existing databases.
- Double-check that updating the logger names to 'eventyay.plugins.eventyay_paypal' matches your logging configuration so no log entries are dropped.
- Verify that renaming the inner plugin class from PretixPluginMeta to EventyayPluginMeta is still recognized by your plugin loader and won’t break plugin discovery.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Ensure that the migration dependency change from 'pretixbase' to 'base' does not disrupt the existing migration graph or require a data migration for existing databases.
- Double-check that updating the logger names to 'eventyay.plugins.eventyay_paypal' matches your logging configuration so no log entries are dropped.
- Verify that renaming the inner plugin class from PretixPluginMeta to EventyayPluginMeta is still recognized by your plugin loader and won’t break plugin discovery.
## Individual Comments
### Comment 1
<location> `eventyay_paypal/apps.py:8-9` </location>
<code_context>
from django.apps import AppConfig
from django.utils.translation import gettext_lazy as _
from . import __version__
try:
from eventyay.base.plugins import PluginConfig
except ImportError:
raise RuntimeError("Python package 'paypal' is not installed.")
</code_context>
<issue_to_address>
**suggestion (code-quality):** Explicitly raise from a previous error ([`raise-from-previous-error`](https://docs.sourcery.ai/Reference/Default-Rules/suggestions/raise-from-previous-error/))
```suggestion
except ImportError as e:
raise RuntimeError("Python package 'paypal' is not installed.") from e
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
mariobehling
requested changes
Oct 11, 2025
The PR is made against enext branch only. |
Gagan-Ram
changed the title
|
I think you misunderstand. https://github.com/fossasia/eventyay-tickets-paypal/tree/enext here in this repo. |
Gagan-Ram
force-pushed
the
chore/enext_global_settings__ey_paypal
branch
from
c2318fd to
a4bc304
Compare
|
@hongquan could you please review this PR. |
hongquan
requested changes
Oct 31, 2025
eventyay_paypal/payment.py
Outdated
| from .utils import safe_get | ||
|
|
||
| logger = logging.getLogger("pretix.plugins.eventyay_paypal") | ||
| logger = logging.getLogger("eventyay.plugins.eventyay_paypal") |
There was a problem hiding this comment.
Please replace all logging.getLogger('xxx') to logging.getLogger(__name__)
There was a problem hiding this comment.
Import of 'PluginConfig' is not used anywhere in app.py, so i remove try catch code and import statement too.
There was a problem hiding this comment.
Pull Request Overview
This pull request migrates the eventyay_paypal plugin from the pretix framework to the eventyay framework. The changes involve updating all import statements, logger names, action type identifiers, and database model references to replace "pretix" with "eventyay" throughout the codebase.
Key changes:
- Updated all import statements from
pretix.*toeventyay.* - Renamed logger identifiers from "pretix.plugins.eventyay_paypal" to "eventyay.plugins.eventyay_paypal"
- Changed action type strings used in logging and signal handlers from "pretix." to "eventyay."
- Updated Django model ForeignKey references from 'pretixbase.' to 'base.'
- Consolidated database migrations and renamed plugin metadata class from
PretixPluginMetatoEventyayPluginMeta
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| eventyay_paypal/views.py | Updated imports from pretix to eventyay modules and changed logger/action type identifiers |
| eventyay_paypal/urls.py | Updated import of event_url from pretix.multidomain to eventyay.multidomain |
| eventyay_paypal/signals.py | Updated imports and all action type string identifiers used in signal handlers |
| eventyay_paypal/paypal_rest.py | Changed logger identifier to use eventyay namespace |
| eventyay_paypal/payment.py | Updated all imports and logger/action type identifiers throughout the payment provider class |
| eventyay_paypal/models.py | Changed ForeignKey references from 'pretixbase' to 'base' for database models |
| eventyay_paypal/migrations/0002_initial.py | Removed this migration file entirely (consolidated into 0001) |
| eventyay_paypal/migrations/0001_initial.py | Updated to consolidate migration, changed dependency from 'pretixbase' to 'base', and updated field types |
| eventyay_paypal/apps.py | Updated import and renamed PretixPluginMeta class to EventyayPluginMeta |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
eventyay_paypal/apps.py
Outdated
|
|
||
| try: | ||
| from pretix.base.plugins import PluginConfig | ||
| from eventyay.base.plugins import PluginConfig |
There was a problem hiding this comment.
Import of 'PluginConfig' is not used.
Gagan-Ram
force-pushed
the
chore/enext_global_settings__ey_paypal
branch
from
a4bc304 to
1765e5b
Compare
mariobehling
approved these changes
Nov 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a part of fossasia/eventyay#1030
Summary by Sourcery
Align PayPal plugin references with the Eventyay namespace by replacing pretix imports, log identifiers, and metadata to use eventyay equivalents
Enhancements: